[PATCH] D128838: [llvm-ar][test] Add additional MRI script testing

[James Henderson via Phabricator via llvm-commits]

jhenderson added inline comments.


================
Comment at: llvm/test/tools/llvm-ar/Inputs/mri-crlf.mri:4
+ADDMOD foo.txt
 end
----------------
It's a bit unfortunate that the capitalization of the commands in this file have different casing. You should probably normalise them.


================
Comment at: llvm/test/tools/llvm-ar/mri-end.test:9
+# RUN: yaml2obj %S/Inputs/elf.yaml -o %t/elf.o
+
+# RUN: llvm-ar -M < empty.mri
----------------
Nit: probably don't want this blank line, or the `## Empty file.` comment needs moving to below it.


================
Comment at: llvm/test/tools/llvm-ar/mri-nonascii.test:20
+# RUN: llvm-ar -M < script.mri
+# RUN: cd %t/extracted && llvm-ar x %t/mri.ar 
 
----------------
Nit: looks like there's trailing whitespace on this line.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128838/new/

https://reviews.llvm.org/D128838