[PATCH] D128806: [RISCV] Fix wrong position of prologue_end
LiqinWeng via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Jun 29 19:02:18 PDT 2022
Miss_Grape added a comment.
In D128806#3619023 <https://reviews.llvm.org/D128806#3619023>, @luismarques wrote:
> Is removing the `if (I != MBB.end()) DL = I->getDebugLoc();` actually correct? I'm wondering why do several other targets have that if it can just be removed.
>
> How about instead adding a `MachineInstr::FrameSetup` flag to the appropriate instructions? That also seems to fix the issue. Don't we want to add that flag anyway?
>
> Does the test actually need to check the DWARF? Can't we just check the assembly, namely that the `.loc prologue_end` directive is inserted in the correct place?
Normally these dwarf information is needed when the debugger is debugging. I don't think it is necessary to add debugging information at this stage(spill/restoreCalleeSavedRegisters).
F23628435: image.png <https://reviews.llvm.org/F23628435>
As shown above, so I removed the debugLoc information at storeRegToStackSlot, also I think also need removed the bugloc at loadRegFromSatckSlot.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D128806/new/
https://reviews.llvm.org/D128806
More information about the llvm-commits
mailing list