[PATCH] D126883: [Debuginfo][DWARF][NFC] Refactor DwarfStringPoolEntryRef.

Wed Jun 29 17:52:31 PDT 2022

vitalybuka reopened this revision.
vitalybuka added a comment.
This revision is now accepted and ready to land.

Msan complains about this patch https://lab.llvm.org/buildbot/#/builders/74/builds/11664/steps/17/logs/stdio

  [ RUN      ] DwarfStringPoolEntryRefTest.TestShortEntry
  Uninitialized bytes in MemcmpInterceptorCommon at offset 20 inside [0x7ffc5d135098, 24)
  ==2198==WARNING: MemorySanitizer: use-of-uninitialized-value
      #0 0x562f6d41b1fc in __interceptor_bcmp /b/sanitizer-x86_64-linux-bootstrap-msan/build/llvm-project/compiler-rt/lib/msan/../sanitizer_common/sanitizer_common_interceptors.inc:978:33
      #1 0x562f6d41b1fc in bcmp /b/sanitizer-x86_64-linux-bootstrap-msan/build/llvm-project/compiler-rt/lib/msan/../sanitizer_common/sanitizer_common_interceptors.inc:973:1
      #2 0x562f6d55d54b in DwarfStringPoolEntryRefTest_TestShortEntry_Test::TestBody() /b/sanitizer-x86_64-linux-bootstrap-msan/build/llvm-project/llvm/unittests/CodeGen/DwarfStringPoolEntryRefTest.cpp:97:3
      #3 0x562f75fec7e4 in HandleExceptionsInMethodIfSupported<testing::Test, void> /b/sanitizer-x86_64-linux-bootstrap-msan/build/llvm-project/llvm/utils/unittest/googletest/src/gtest.cc
      #4 0x562f75fec7e4 in testing::Test::Run() /b/sanitizer-x86_64-linux-bootstrap-msan/build/llvm-project/llvm/utils/unittest/googletest/src/gtest.cc:2508:5
      #5 0x562f75ff14c4 in testing::TestInfo::Run() /b/sanitizer-x86_64-linux-bootstrap-msan/build/llvm-project/llvm/utils/unittest/googletest/src/gtest.cc:2684:11
      #6 0x562f75ff3070 in testing::TestSuite::Run() /b/sanitizer-x86_64-linux-bootstrap-msan/build/llvm-project/llvm/utils/unittest/googletest/src/gtest.cc:2816:28
      #7 0x562f76025691 in testing::internal::UnitTestImpl::RunAllTests() /b/sanitizer-x86_64-linux-bootstrap-msan/build/llvm-project/llvm/utils/unittest/googletest/src/gtest.cc:5338:44
      #8 0x562f76023dff in HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool> /b/sanitizer-x86_64-linux-bootstrap-msan/build/llvm-project/llvm/utils/unittest/googletest/src/gtest.cc
      #9 0x562f76023dff in testing::UnitTest::Run() /b/sanitizer-x86_64-linux-bootstrap-msan/build/llvm-project/llvm/utils/unittest/googletest/src/gtest.cc:4925:10
      #10 0x562f6d7918cf in RUN_ALL_TESTS /b/sanitizer-x86_64-linux-bootstrap-msan/build/llvm-project/llvm/utils/unittest/googletest/include/gtest/gtest.h:2472:46
      #11 0x562f6d7918cf in main /b/sanitizer-x86_64-linux-bootstrap-msan/build/llvm-project/llvm/unittests/CodeGen/TargetOptionsTest.cpp:76:10
      #12 0x7f6d31eb409a in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x2409a) (BuildId: eb6a5dd378d22b1e695984462a799cd4c81cdc22)
      #13 0x562f6d3c3d69 in _start (/b/sanitizer-x86_64-linux-bootstrap-msan/build/llvm_build_msan_track_origins/unittests/CodeGen/CodeGenTests+0x2f80d69)
    Uninitialized value was created by an allocation of 'DwarfEntry2' in the stack frame of function '_ZN47DwarfStringPoolEntryRefTest_TestShortEntry_Test8TestBodyEv'
      #0 0x562f6d558fc0 in DwarfStringPoolEntryRefTest_TestShortEntry_Test::TestBody() /b/sanitizer-x86_64-linux-bootstrap-msan/build/llvm-project/llvm/unittests/CodeGen/DwarfStringPoolEntryRefTest.cpp:57
  SUMMARY: MemorySanitizer: use-of-uninitialized-value /b/sanitizer-x86_64-linux-bootstrap-msan/build/llvm-project/compiler-rt/lib/msan/../sanitizer_common/sanitizer_common_interceptors.inc:978:33 in __interceptor_bcmp
  Exiting

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126883/new/

https://reviews.llvm.org/D126883