[PATCH] D128148: [XCOFF] write the aux header when the visibility is specified in XCOFF32.
Digger Lin via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Jun 29 13:28:26 PDT 2022
DiggerLin added inline comments.
================
Comment at: llvm/lib/MC/XCOFFObjectWriter.cpp:462
+ if (XSym->getVisibilityType())
+ HasVisibility = true;
----------------
maybe more readable to change to
if (XSym->getVisibilityType() !=XCOFF::SYM_V_UNSPECIFIED)
================
Comment at: llvm/lib/MC/XCOFFObjectWriter.cpp:760
if (is64Bit()) {
- W.write<uint16_t>(0); // AuxHeaderSize. No optional header for an object
- // file that is not to be loaded.
+ W.write<uint16_t>(0); // AuxHeaderSize.
W.write<uint16_t>(0); // Flags
----------------
since in function auxiliaryHeaderSize() , 64bit return size zero, can we use auxiliaryHeaderSize() here ?
================
Comment at: llvm/lib/MC/XCOFFObjectWriter.cpp:783
+ W.write<uint32_t>(0); // TextStartAddr
+ W.write<uint32_t>(0); // DataStartAddr
+}
----------------
since we can know the address and Size from stuct SectionEntry , do you want to put the value here instead of zero?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D128148/new/
https://reviews.llvm.org/D128148
More information about the llvm-commits
mailing list