[PATCH] D127854: [InstCombine] Use known bits to determine exact int->fp cast
Sanjay Patel via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Jun 29 13:06:13 PDT 2022
spatel accepted this revision.
spatel added a comment.
This revision is now accepted and ready to land.
LGTM - clearly, we can still do better, but this seems like a safe improvement.
================
Comment at: llvm/lib/Transforms/InstCombine/InstCombineCasts.cpp:1757
- // TODO:
// Try harder to find if the source integer type has less significant bits.
// For example, compute number of sign bits or compute low bit mask.
----------------
Please leave the TODO note. We could still check sign bits rather than zeros or do some other kind of refinement.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D127854/new/
https://reviews.llvm.org/D127854
More information about the llvm-commits
mailing list