[PATCH] D128364: [InstCombine] Look through more casts when folding memchr and memcmp

[Martin Sebor via Phabricator via llvm-commits]

msebor added a comment.

I agree there is a detectable difference when folding either undefined calls to `atoi` (or `strtol`) either with past the end pointers, or even with the empty string.  The former calls are undefined so the difference shouldn't matter, but this latter is well-defined.  In the latter case the difference predates the patch which is why I just "papered" over it by disabling the test, but I agree it should be avoided.  I've raised PR 56293 <https://github.com/llvm/llvm-project/issues/56293> to keep track of it and will look into removing it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128364/new/

https://reviews.llvm.org/D128364