[PATCH] D128839: [DirectX backend] Add createHandle BufferLoad/Store DXIL operation

[Xiang Li via Phabricator via llvm-commits]

python3kgae added inline comments.


================
Comment at: llvm/include/llvm/IR/IntrinsicsDXIL.td:22
+
+def int_dxil_buffer_load : Intrinsic<[ llvm_any_ty, LLVMMatchType<0>, LLVMMatchType<0>, LLVMMatchType<0>, llvm_i32_ty ],
+ [ llvm_i64_ty, llvm_i32_ty, llvm_i32_ty], [IntrReadMem, IntrWillReturn]>;
----------------
beanz wrote:
> Do you have a plan for taking LLVM load instructions and converting them to these intrinsics?
> 
> I think we need to think about how we want to translate LLVM gep/load/store instructions into DXIL ops, and I don't think we should add these intrinsics until we know what that is going to look like.
These intrinsics are trying to make the distance from hlsl to DXIL shorter.
They're just wrapper for DXIL operation functions so generate DXIL is easier.

 I did experiment to generate DXIL directly from GEP/load/store, then found create intrinsic might help the translation.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128839/new/

https://reviews.llvm.org/D128839