[PATCH] D127990: [DirectX] add thread/group id DXIL operations.

[Chris Bieneman via Phabricator via llvm-commits]

beanz added a comment.

Two small nits. Otherwise, looks good.



================
Comment at: llvm/include/llvm/IR/IntrinsicsDXIL.td:1
+//===- IntrinsicsDXIL.td - Defines DXIL intrinsics -----*- tablegen -*-===//
+//
----------------
We should name this file IntrinsicsDirectX.td not DXIL since it will be all the target intrinsics, and the header should be updated accordingly.


================
Comment at: llvm/include/llvm/IR/IntrinsicsDXIL.td:9
+//
+// This file defines all of the R600-specific intrinsics.
+//
----------------
This should be DirectX-specific not R600 :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127990/new/

https://reviews.llvm.org/D127990