[PATCH] D128773: [BOLT] Add option to randomize function split point

[Fabian Parzefall via Phabricator via llvm-commits]

FPar marked 2 inline comments as done.
FPar added a comment.

Thanks for your suggestions! @Amir



================
Comment at: bolt/lib/Passes/SplitFunctions.cpp:147-150
+    LLVM_DEBUG(dbgs() << formatv("BOLT-DEBUG: randomly chose last {0} (out of "
+                                 "{1} possible) blocks to split\n",
+                                 ColdEnd - OutlineableBegin,
+                                 OutlineableEnd - OutlineableBegin));
----------------
Amir wrote:
> As a matter of preference - I try to wrap LLVM_DEBUG body with curly braces to indent it just like a regular code block.
I see your point. However, the majority of our code base seems to omit curly braces in this place. So if you don't mind, I'll keep it like that for now.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128773/new/

https://reviews.llvm.org/D128773