[PATCH] D127041: [LLVM] Add the support for fmax and fmin in atomicrmw instruction

Shilei Tian via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 29 07:56:54 PDT 2022


tianshilei1992 marked an inline comment as done.
tianshilei1992 added inline comments.


================
Comment at: llvm/test/Bitcode/compatibility.ll:870
+; CHECK: %atomicrmw.fmin = atomicrmw fmin float* %word, float 1.000000e+00 monotonic
+  %atomicrmw.fmin = atomicrmw fmin float* %word, float 1.0 monotonic
+
----------------
tianshilei1992 wrote:
> arsenm wrote:
> > Since you also touched dxil, is an additional test needed for dxil encoding?
> Thanks for catching that. Will do.
I took a quick look at tests for DXIL. There is no test for `atomicrmw` stuff. The test coverage is fairly minimum. I think at this moment, we could skip that.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127041/new/

https://reviews.llvm.org/D127041



More information about the llvm-commits mailing list