[PATCH] D128806: [RISCV] Fix wrong position of prologue_end

[Luís Marques via Phabricator via llvm-commits]

luismarques added a comment.

Is removing the `if (I != MBB.end()) DL = I->getDebugLoc();` actually correct? I'm wondering why do several other targets have that if it can just be removed.

How about instead adding a `MachineInstr::FrameSetup` flag to the appropriate instructions? That also seems to fix the issue. Don't we want to add that flag anyway?

Does the test actually need to check the DWARF? Can't we just check the assembly, namely that the `.loc prologue_end` directive is inserted in the correct place?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128806/new/

https://reviews.llvm.org/D128806