[llvm] 7758f3a - [AMDGPU] Remove FIXMEs that were resolved by D30134

Jay Foad via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 29 06:43:17 PDT 2022


Author: Jay Foad
Date: 2022-06-29T14:43:11+01:00
New Revision: 7758f3aa9683118681be79a7379d38f5effefd87

URL: https://github.com/llvm/llvm-project/commit/7758f3aa9683118681be79a7379d38f5effefd87
DIFF: https://github.com/llvm/llvm-project/commit/7758f3aa9683118681be79a7379d38f5effefd87.diff

LOG: [AMDGPU] Remove FIXMEs that were resolved by D30134

Added: 
    

Modified: 
    llvm/test/CodeGen/AMDGPU/clamp.ll

Removed: 
    


################################################################################
diff  --git a/llvm/test/CodeGen/AMDGPU/clamp.ll b/llvm/test/CodeGen/AMDGPU/clamp.ll
index f8bd575d7fa9f..f1da504c33656 100644
--- a/llvm/test/CodeGen/AMDGPU/clamp.ll
+++ b/llvm/test/CodeGen/AMDGPU/clamp.ll
@@ -139,7 +139,6 @@ define amdgpu_kernel void @v_clamp_f16(half addrspace(1)* %out, half addrspace(1
 ; GCN: {{buffer|flat|global}}_load_ushort [[A:v[0-9]+]]
 ; GFX89: v_max_f16_e64 v{{[0-9]+}}, -[[A]], -[[A]] clamp{{$}}
 
-; FIXME: Better to fold neg into max
 ; SI: v_cvt_f32_f16_e64 [[CVT:v[0-9]+]], -[[A]] clamp{{$}}
 ; SI: v_cvt_f16_f32_e32 v{{[0-9]+}}, [[CVT]]
 define amdgpu_kernel void @v_clamp_neg_f16(half addrspace(1)* %out, half addrspace(1)* %aptr) #0 {
@@ -159,8 +158,6 @@ define amdgpu_kernel void @v_clamp_neg_f16(half addrspace(1)* %out, half addrspa
 ; GCN: {{buffer|flat|global}}_load_ushort [[A:v[0-9]+]]
 ; GFX89: v_max_f16_e64 v{{[0-9]+}}, -|[[A]]|, -|[[A]]| clamp{{$}}
 
-; FIXME: Better to fold neg/abs into max
-
 ; SI: v_cvt_f32_f16_e64 [[CVT:v[0-9]+]], -|[[A]]| clamp{{$}}
 ; SI: v_cvt_f16_f32_e32 v{{[0-9]+}}, [[CVT]]
 define amdgpu_kernel void @v_clamp_negabs_f16(half addrspace(1)* %out, half addrspace(1)* %aptr) #0 {


        


More information about the llvm-commits mailing list