[PATCH] D30134: AMDGPU: Fold FP clamp as modifier bit

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 29 06:16:05 PDT 2022


arsenm added inline comments.


================
Comment at: test/CodeGen/AMDGPU/clamp.ll:108
 
 ; FIXME: Better to fold neg into max
+; SI: v_cvt_f32_f16_e64 [[CVT:v[0-9]+]], -[[A]] clamp{{$}}
----------------
foad wrote:
> Does this FIXME still make sense? Not sure what it was trying to say in the first place.
The source modifier is used here, so I don't think so


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D30134/new/

https://reviews.llvm.org/D30134



More information about the llvm-commits mailing list