[PATCH] D128474: [BOLT] Support multiple parents for split jump table

[Amir Ayupov via Phabricator via llvm-commits]

Amir added a comment.

Looks good, with a couple of final nits.



================
Comment at: bolt/lib/Core/BinaryContext.cpp:828
+  JT->Parents.push_back(&Function);
+  JT->print(outs());
   JumpTables.emplace(Address, JT);
----------------
Please keep the verbosity here


================
Comment at: bolt/lib/Core/BinaryFunction.cpp:1661
+        // skip if builtin_unreachable
+        bool skipEntry = false;
+        for (BinaryFunction *Parent : JT.Parents)
----------------
The variables must be upper-cased according to LLVM Style Guide: https://llvm.org/docs/CodingStandards.html#name-types-functions-variables-and-enumerators-properly


================
Comment at: bolt/lib/Core/BinaryFunction.cpp:1662-1666
+        for (BinaryFunction *Parent : JT.Parents)
+          if (EntryAddress == Parent->getAddress() + Parent->getSize()) {
+            skipEntry = true;
+            break;
+          }
----------------



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128474/new/

https://reviews.llvm.org/D128474