[PATCH] D127569: [RISCV]Precommit test of D127568

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 28 23:06:19 PDT 2022


MaskRay added inline comments.


================
Comment at: llvm/test/CodeGen/RISCV/unnecessary-code-align.ll:1
+; RUN: llc -mtriple=riscv64 -filetype=obj -mattr=+c,+relax %s -o - \
+; RUN:     | llvm-readobj -r - | FileCheck %s
----------------
Ideally, you just find where `-mattr=-c,+relax` is tested, add add the `+c` test there.


================
Comment at: llvm/test/CodeGen/RISCV/unnecessary-code-align.ll:5
+; CHECK: Relocations [
+; CHECK:   Section (3) .rela.text {
+; CHECK:     0x0 R_RISCV_ALIGN - 0x2
----------------
Add -NEXT whenever applicable.


================
Comment at: llvm/test/CodeGen/RISCV/unnecessary-code-align.ll:15
+attributes #0 = { nounwind }
+
----------------
remove trailing blank line


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127569/new/

https://reviews.llvm.org/D127569



More information about the llvm-commits mailing list