[PATCH] D128203: [OpenMP][IRBuilder] Add support for taskgroup

[Shraiysh via Phabricator via llvm-commits]

shraiysh added a comment.

In D128203#3614064 <https://reviews.llvm.org/D128203#3614064>, @peixin wrote:

> In D128203#3612147 <https://reviews.llvm.org/D128203#3612147>, @shraiysh wrote:
>
>> In D128203#3600984 <https://reviews.llvm.org/D128203#3600984>, @peixin wrote:
>>
>>> One general question: can this be used for clang? Usually the clang side is also supported when supporting some new constructs/clauses in OMPIRBuilder?
>>
>> I think it can be used for clang. No clause is handled here and so I cannot replace clang's taskgroup generation with this function right now, but there is no special Fortran handling here.
>
> No need to replace clang. Here is one example(D114379 <https://reviews.llvm.org/D114379>). You can use `-fopenmp-enable-irbuilder`. It is good to have the initial running test using c/c++ code for OMPIRBuilder implementation. But this is not one hard suggestion considering our higher priority is to implement this for Flang.

Thanks for this. I will add clang code generation too.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128203/new/

https://reviews.llvm.org/D128203