[PATCH] D127383: Don't treat readnone call in presplit coroutine as not access memory

[Chuanqi Xu via Phabricator via llvm-commits]

ChuanqiXu marked an inline comment as done.
ChuanqiXu added inline comments.


================
Comment at: llvm/include/llvm/IR/InstrTypes.h:1856
+           // Since readnone could be used for thread identification and
+           // coroutines might resume in different threads.
+           (!getFunction() || !getFunction()->isPresplitCoroutine());
----------------
efriedma wrote:
> Probably we should describe this in more detail in the coroutine documentation, and put a pointer to that documentation in the code.
I've added a description in Coroutines.rst but it is not more detailed than this. Do you mean to give more thoughts we've made in https://discourse.llvm.org/t/address-thread-identification-problems-with-coroutine/62015? I feel it is too wordy for readers.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127383/new/

https://reviews.llvm.org/D127383