[PATCH] D128474: [BOLT] Support multiple parents for split jump table

Huan Nguyen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 28 20:23:44 PDT 2022


nhuhuan added inline comments.


================
Comment at: bolt/lib/Core/BinaryFunction.cpp:1687
+      uint64_t EntryAddress = JT->EntriesAsAddress[EntryOffset / JT->EntrySize];
+      uint64_t EntryOffset = EntryAddress - getAddress();
+      if (EntryOffset < getSize()) {
----------------
Using same variable name "EntryOffset" is completely wrong, and may potentially trigger memory over-use!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128474/new/

https://reviews.llvm.org/D128474



More information about the llvm-commits mailing list