[PATCH] D127383: Don't treat readnone call in presplit coroutine as not access memory

[Eli Friedman via Phabricator via llvm-commits]

efriedma added a comment.

We probably want to put a note in LangRef noting that "readnone" doesn't encompass the thread id in coroutines.



================
Comment at: llvm/include/llvm/IR/InstrTypes.h:1856
+           // Since readnone could be used for thread identification and
+           // coroutines might resume in different threads.
+           (!getFunction() || !getFunction()->isPresplitCoroutine());
----------------
Probably we should describe this in more detail in the coroutine documentation, and put a pointer to that documentation in the code.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127383/new/

https://reviews.llvm.org/D127383