[PATCH] D124686: [Symbolize] Parser for log symbolizer markup.

David Blaikie via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 28 14:18:06 PDT 2022


dblaikie added a comment.

In D124686#3616216 <https://reviews.llvm.org/D124686#3616216>, @mysterymath wrote:

> In D124686#3598029 <https://reviews.llvm.org/D124686#3598029>, @dblaikie wrote:
>
>> Is it already planned to add this markup to LLVM's own crash dumps when they aren't already symbolized? Might be a handy use-case for the feature, providing some built-in-to-llvm exercisizing/advertising/experience with the feature? (if the markup is meant to be compatible with human readers who might not be able to symbolize the data later - which seems like a nice feature too)
>
> We've had a few discussions about this; I think broadly yes, although we haven't hashed out the full details yet. One of the options would be to always emit symbolizer markup in LLVM, then pass it to a forked llvm-symbolizer instance if one can be found. That way, you'd get online symbolization if possible, but graceful degradation to markup if not.

Ah, that makes sense - yeah, I was wondering/figuring the markup probably wasn't human readable, so always passing it through the processor, which can either add the symbolizing info, or at least remove the markup if there's no debug info/other symbolizing to do, etc.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124686/new/

https://reviews.llvm.org/D124686



More information about the llvm-commits mailing list