[PATCH] D87656: [llvm-dwarfdump] --show-sources option to show all sources

Tue Jun 28 13:38:31 PDT 2022

mysterymath added inline comments.

================
Comment at: llvm/test/tools/llvm-dwarfdump/X86/sources.test:1-3
+# RUN: yaml2obj --docnum=1 %s -o - \
+# RUN: | llvm-dwarfdump --show-sources - \
+# RUN: | FileCheck --check-prefix=CU-NAME-CHECK %s
----------------
jhenderson wrote:
> jhenderson wrote:
> > Up to you, but I have a personal preference for this formatting, as it indicates on each line that there is a continuation involved, starting with a new command.
> > 
> > Also, I personally prefer it if tests create objects on disk rather than passing them via stdin. This is because it's easier to directly inspect the binary if there's a problem with the test. Otherwise, you have to (temporarily) modify the test to force it to dump it.
> > 
> > Same comments apply elsewhere.
> You missed the space indentation I included in my suggested edit.
Not sure what you mean here; I'm seeing three space indentation from the colon in `RUN:` in both the code and your suggested edit.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87656/new/

https://reviews.llvm.org/D87656