[PATCH] D126811: [ARM64EC 10/?] Add support for lowering indirect calls.

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 28 12:21:52 PDT 2022


efriedma added inline comments.


================
Comment at: llvm/lib/Target/AArch64/AArch64Arm64ECCallLowering.cpp:223
+  GuardFnCFGlobal =
+      M->getOrInsertGlobal("__os_arm64x_check_icall_cfg", GuardFnPtrType);
+  GuardFnGlobal =
----------------
bcl5980 wrote:
> For now MSVC(19.32.31329/19.33.31517) use a different function name `__os_arm64x_dispatch_icall_cfg`, `__os_arm64x_dispatch_icall`. 
> But the document is still using `__os_arm64x_check_icall_cfg`, `__os_arm64x_check_icall`
> Not sure which one Microsoft will use finally.
I assume that, for ABI reasons, the MIcrosoft libraries will continue to expose both versions.  So it probably doesn't really matter which one we use.

I assume the semantics match the CFG functions on other targets; see llvm/lib/Transforms/CFGuard/CFGuard.cpp .


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126811/new/

https://reviews.llvm.org/D126811



More information about the llvm-commits mailing list