[PATCH] D127119: [SLP]Fix undef handling in gather function.

Harald van Dijk via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 28 12:03:57 PDT 2022


hvdijk added inline comments.


================
Comment at: llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp:9069-9072
+                     std::distance(
+                         SI2->operands().begin(),
+                         find_if(SI2->operands(),
+                                 [VecOp2](Value *Op) { return Op = VecOp2; })) *
----------------
vporpo wrote:
> This also repeats in line 9054. Perhaps move it to a lambda like `getOperandIndex(SI2, VecOp2)` ?
Actually... That just looks very wrong, `=` rather than `==`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127119/new/

https://reviews.llvm.org/D127119



More information about the llvm-commits mailing list