[PATCH] D128302: [AArch64][CostModel] Detects that ExtractElement at index is not free in AArch64 when result is used as integer.

David Li via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 28 11:29:53 PDT 2022


davidxl added inline comments.


================
Comment at: llvm/lib/Target/AArch64/AArch64TargetTransformInfo.cpp:1900
       return 0;
   }
 
----------------
mingmingl wrote:
> davidxl wrote:
> > missing return instruction ?
> This falls through to use `ST->getVectorInsertExtractBaseCost()` around line 1903. Basically, this patch reduces the case when extracting element at index 0 is considered free (using truck as a baseline).
ok -- my view of the patch hides the line :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128302/new/

https://reviews.llvm.org/D128302



More information about the llvm-commits mailing list