[PATCH] D128344: [AMDGPU] Add the uses_dynamic_stack field to the kernel descriptor

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 28 11:13:23 PDT 2022


arsenm added a comment.

In D128344#3616164 <https://reviews.llvm.org/D128344#3616164>, @abinavpp wrote:

> In D128344#3615280 <https://reviews.llvm.org/D128344#3615280>, @arsenm wrote:
>
>> I see the kernel descriptor changes reflected in the test updates, but I don't see the metadata entries tested
>
> By "metadata entries", do you mean an entry in the kernel metadata map under NT_AMDGPU_METADATA? I didn't add the corresponding field there.

Yes. It has .private_segment_fixed_size, so should also have this for consistency


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128344/new/

https://reviews.llvm.org/D128344



More information about the llvm-commits mailing list