[PATCH] D128719: [IR] Remove support for insertvalue constant expression

[Nikita Popov via Phabricator via llvm-commits]

nikic added a comment.

In D128719#3615789 <https://reviews.llvm.org/D128719#3615789>, @reames wrote:

> Can I ask you to separate the various construction to fold changes into a separate NFC?  I'd like to see that land and bake for a couple days before the removal itself goes in.

I can do that, though this wouldn't be an NFC change, as we won't create an expression for the case where the expression doesn't fold (of course, this makes little difference in practice because insertvalue pretty much always folds).

> Don't we have to worry about forward compatibility with bitcode on this one?  I didn't see anything for that in this change?

`insertvalue` is another expression not supported in bitcode. It's the last one though, other ones will need the bitcode part.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128719/new/

https://reviews.llvm.org/D128719