[PATCH] D128591: Transforms: Relax restrictions on pow(x, y) expansion
David Sherwood via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Jun 28 09:02:47 PDT 2022
david-arm added a reviewer: spatel.
david-arm added a subscriber: spatel.
david-arm added a comment.
The patch looks good to me. However, @spatel is more familiar than me with the semantics of fast-math flags on operations, so adding as a reviewer in case I've missed something!
================
Comment at: llvm/test/Transforms/InstCombine/pow-4.ll:65
+;
+ %1 = call reassoc nnan ninf nsz double @llvm.pow.f64(double %x, double 4.000000e+00)
+ ret double %1
----------------
nit: Can you remove nsz here too?
================
Comment at: llvm/test/Transforms/InstCombine/pow-4.ll:125
+;
+ %1 = call reassoc nnan ninf nsz float @llvm.pow.f32(float %x, float -1.900000e+01)
+ ret float %1
----------------
nit: Can you remove nsz here too?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D128591/new/
https://reviews.llvm.org/D128591
More information about the llvm-commits
mailing list