[PATCH] D114174: [ARM][CodeGen] Add support for complex addition and multiplication

Momchil Velikov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 28 07:46:21 PDT 2022


chill added inline comments.


================
Comment at: llvm/test/CodeGen/ARM/ComplexArithmetic/complex-arithmetic-f32-add.ll:99
+  %b.imag = shufflevector <8 x float> %b, <8 x float> zeroinitializer, <4 x i32> <i32 1, i32 3, i32 5, i32 7>
+  %0 = fsub fast <4 x float> %b.real, %a.imag
+  %1 = fadd fast <4 x float> %b.imag, %a.real
----------------
chill wrote:
> Shouldn't these be translated  to a couple of `vcadd.f32` instructions, like in the previous test?
> And this amount of move instructions seems excessive.
> And this amount of move instructions seems excessive.
I guess MVE does not have sensible swizzling instructions.



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114174/new/

https://reviews.llvm.org/D114174



More information about the llvm-commits mailing list