[PATCH] D128539: [GISel] Don't fold convergent instruction across CFG
Matt Arsenault via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Jun 28 05:23:58 PDT 2022
arsenm added a comment.
I'm not sure what context this gets called in. Maybe it's possible to hit this for DPP instructions?
================
Comment at: llvm/lib/CodeGen/GlobalISel/InstructionSelector.cpp:63
+ // Convergent instructions cannot be moved in the CFG.
+ if (MI.isConvergent() && MI.getParent() != IntoMI.getParent())
+ return false;
----------------
The block based check will probably break down with convergence tokens. Could this just skip convergent altogether?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D128539/new/
https://reviews.llvm.org/D128539
More information about the llvm-commits
mailing list