[PATCH] D128342: [LoopVectorize] Disable tail-folding when masked interleaved accesses are unavailable

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 28 02:44:42 PDT 2022


fhahn added inline comments.


================
Comment at: llvm/test/Transforms/LoopVectorize/AArch64/sve-tail-folding-interleave.ll:1
+; RUN: opt -loop-vectorize -S -prefer-predicate-over-epilogue=predicate-else-scalar-epilogue \
+; RUN:   -debug < %s 2>%t | FileCheck %s
----------------
sdesmalen wrote:
> Why is this loop still vectorized with a VF of 8?
This needs `REQUIRES: asserts` I think, as it uses `-debug`, same for the other test. Could. you precommit the tests, so only the impact of the patch is shown in this diff?


================
Comment at: llvm/test/Transforms/LoopVectorize/AArch64/sve-tail-folding-interleave.ll:9
+
+define void @foo(ptr noalias nocapture noundef writeonly %dst, ptr noalias nocapture noundef readonly %src, i64 noundef %n) #0 {
+; CHECK-LABEL: @foo(
----------------
nit: everything expcept the `no alias` attribute appears to be unnecessary


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128342/new/

https://reviews.llvm.org/D128342



More information about the llvm-commits mailing list