[PATCH] D121346: [Propeller] Encode address offsets of basic blocks relative to the end of the previous basic blocks.

[James Henderson via Phabricator via llvm-commits]

jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.

Two nits, otherwise LGTM.



================
Comment at: llvm/lib/ObjectYAML/ELFEmitter.cpp:1401
+                             << static_cast<int>(E.Version)
+                             << ", encoding using the most recent version";
+      CBA.write(E.Version);
----------------
Nit: semi-colon rather than comma is probably more correct


================
Comment at: llvm/test/tools/yaml2obj/ELF/bb-addr-map.yaml:138
+
+## Check that yaml2obj generates warning when we use unsupported versions.
+# RUN: yaml2obj --docnum=3  %s 2>&1 | FileCheck %s --check-prefix=INVALID-VERSION
----------------



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121346/new/

https://reviews.llvm.org/D121346