[PATCH] D128260: [Fortran] Ignore whitespace in FCVS test results

Diana Picus via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 28 00:49:17 PDT 2022


rovka updated this revision to Diff 440511.
rovka set the repository for this revision to rT test-suite.
rovka added a comment.

No change, trying to convince the pre-merge to apply the patch...


Repository:
  rT test-suite

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128260/new/

https://reviews.llvm.org/D128260

Files:
  Fortran/UnitTests/fcvs21_f95/CMakeLists.txt
  cmake/modules/SingleMultiSource.cmake


Index: cmake/modules/SingleMultiSource.cmake
===================================================================
--- cmake/modules/SingleMultiSource.cmake
+++ cmake/modules/SingleMultiSource.cmake
@@ -128,6 +128,9 @@
     if(FP_ABSTOLERANCE)
       set(DIFFPROG "${DIFFPROG} -a ${FP_ABSTOLERANCE}")
     endif()
+    if(FP_IGNOREWHITESPACE)
+      set(DIFFPROG "${DIFFPROG} -i")
+    endif()
     llvm_test_verify(${DIFFPROG} %o %S/${REFERENCE_OUTPUT})
     llvm_test_data(${target} ${REFERENCE_OUTPUT})
   endif()
Index: Fortran/UnitTests/fcvs21_f95/CMakeLists.txt
===================================================================
--- Fortran/UnitTests/fcvs21_f95/CMakeLists.txt
+++ Fortran/UnitTests/fcvs21_f95/CMakeLists.txt
@@ -33,7 +33,23 @@
 # clean-up fort.* files otherwise one of the tests will fail
 llvm_test_prepare(rm -f %S/fort.*)
 
+# Group 1:
+# Tests 905 and 907 use list-directed output, for which the standard allows some
+# flexibility, e.g.,  with regards to how many white space characters or
+# floating point decimals to print. Treat them separately.
+set(SPECIAL_CASES "FM905.f" "FM907.f")
+set(Source ${SPECIAL_CASES})
+set(FP_IGNOREWHITESPACE ON)
+llvm_singlesource()
+set(Source)
+
+# Group 2:
+# Generic case. Make sure to exclude the special cases which have already been
+# added as part of Group 1.
 file(GLOB Source CONFIGURE_DEPENDS *.f)
+foreach (SPECIAL_CASE ${SPECIAL_CASES})
+  list(FILTER Source EXCLUDE REGEX ${SPECIAL_CASE})
+endforeach()
 
 # Test 509 requires this flag in more recent versions of GCC.
 # If this flag is not supported, the test should be excluded.
@@ -46,6 +62,7 @@
 endif()
 
 set(FP_TOLERANCE 1.0e-11) # set by the most sensitive numerical test
+set(FP_IGNOREWHITESPACE OFF)
 llvm_singlesource()
 
 file(COPY lit.local.cfg DESTINATION "${CMAKE_CURRENT_BINARY_DIR}")


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D128260.440511.patch
Type: text/x-patch
Size: 1830 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220628/a2a5911b/attachment.bin>


More information about the llvm-commits mailing list