[PATCH] D127972: [AsmPrinter] Further restrict expressions supported in global initializers

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 28 00:28:24 PDT 2022


MaskRay added a comment.

This looks good to me. `switch (CE->getOpcode()) { ` should have a comment. The supported ConstantExpression opcodes are to support relocations for non-compile-time-constant values.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127972/new/

https://reviews.llvm.org/D127972



More information about the llvm-commits mailing list