[PATCH] D128626: [llvm-ar] Add --output to specify output directory

[James Henderson via Phabricator via llvm-commits]

jhenderson added inline comments.


================
Comment at: llvm/test/tools/llvm-ar/extract.test:38
+
+## --output specifies the directory to extract archive members to. `1/2` is created.
+# RUN: llvm-ar --output=1/2 x %t/archive.a
----------------
I think it helps to be explicit here.


================
Comment at: llvm/tools/llvm-ar/llvm-ar.cpp:568
+  } else {
+    failIfError(sys::fs::create_directories(OutputDir));
+    sys::path::append(path, OutputDir, sys::path::filename(Name));
----------------
Probably need a test case that the potential error is handled correctly. This should be easy to create by simply having a file where a directory is expected.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128626/new/

https://reviews.llvm.org/D128626