[PATCH] D128688: [llvm-objcopy] Remove support for legacy .zdebug sections

[James Henderson via Phabricator via llvm-commits]

jhenderson added a subscriber: plotfi.
jhenderson added a comment.

@plotfi, you were the one who originally added compression support, including zlib-gnu support. Do you know of a use-case for zlib-gnu support? If not, I think we can drop it, given that GNU has. (Looking back at https://reviews.llvm.org/D49678#1189341 which was a comment I made on the review to add support,  @plotfi originally had this marked as deprecated).



================
Comment at: llvm/lib/ObjCopy/ELF/ELFObject.cpp:522
   uint8_t *Buf = reinterpret_cast<uint8_t *>(Out.getBufferStart()) + Sec.Offset;
   if (Sec.CompressionType == DebugCompressionType::None) {
     std::copy(Sec.OriginalData.begin(), Sec.OriginalData.end(), Buf);
----------------
I wonder if this should be a switch statement, so that we can benefit from compiler diagnostics if not all `DebugCompressionType` values are handled. Thoughts?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128688/new/

https://reviews.llvm.org/D128688