[PATCH] D127729: [Bitcode] Support expanding constant expressions into instructions

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 27 23:52:45 PDT 2022


MaskRay added inline comments.


================
Comment at: llvm/lib/Bitcode/Reader/ValueList.h:34
 
-  /// As we resolve forward-referenced constants, we add information about them
-  /// to this vector.  This allows us to resolve them in bulk instead of
-  /// resolving each reference at a time.  See the code in
-  /// ResolveConstantForwardRefs for more information about this.
-  ///
-  /// The key of this vector is the placeholder constant, the value is the slot
-  /// number that holds the resolved value.
-  using ResolveConstantsTy = std::vector<std::pair<Constant *, unsigned>>;
-  ResolveConstantsTy ResolveConstants;
   LLVMContext &Context;
 
----------------
Unused now? `warning: private field 'Context' is not used [-Wunused-private-field]`


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127729/new/

https://reviews.llvm.org/D127729



More information about the llvm-commits mailing list