[PATCH] D127729: [Bitcode] Support expanding constant expressions into instructions
Fangrui Song via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Jun 27 23:40:56 PDT 2022
MaskRay added inline comments.
================
Comment at: llvm/lib/Bitcode/Reader/BitcodeReader.cpp:3235
+ Alloc, CurTy,
+ {OpTy->isFPOrFPVectorTy() ? Instruction::FCmp : Instruction::ICmp,
+ (uint8_t)Record[3]},
----------------
```
/home/maskray/llvm/llvm/lib/Bitcode/Reader/BitcodeReader.cpp:3235:12: error: non-constant-expression cannot be narrowed from type 'llvm::Instruction::OtherOps' to 'uint8_t' (aka 'unsigned char') in initializer list [-Wc++11-narrowing]
{OpTy->isFPOrFPVectorTy() ? Instruction::FCmp : Instruction::ICmp,
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
Add a uint8_t cast
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D127729/new/
https://reviews.llvm.org/D127729
More information about the llvm-commits
mailing list