[PATCH] D128188: [RISCV] Add a scavenge spill slot when use ADDI to compute scalable stack offset

luxufan via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 27 23:36:54 PDT 2022


StephenFan marked an inline comment as done.
StephenFan added inline comments.


================
Comment at: llvm/lib/Target/RISCV/RISCVRegisterInfo.cpp:177
       getFrameLowering(MF)->getFrameIndexReference(MF, FrameIndex, FrameReg);
-  bool IsRVVSpill = RISCV::isRVVSpill(MI, /*CheckFIs*/ false);
+  bool IsRVVSpill = RISCV::isRVVSpill(MI);
   if (!IsRVVSpill)
----------------
craig.topper wrote:
> Is `IsRVVSpill` used anywhere other than the following if? If not can we call RICV::isRVVSpill as part of the `if` and remove the variable.
It is used on lines 262 and 272.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128188/new/

https://reviews.llvm.org/D128188



More information about the llvm-commits mailing list