[PATCH] D128188: [RISCV] Add a scavenge spill slot when use ADDI to compute scalable stack offset

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.


================
Comment at: llvm/lib/Target/RISCV/RISCVFrameLowering.cpp:975
+        if (IsRVVSpill) {
+          GlobalMostScavSlotsNum = std::max(
+              GlobalMostScavSlotsNum,
----------------
Drop "Global". Without Local it doesn't mean anything.

Replace "Most" with "Max"


================
Comment at: llvm/lib/Target/RISCV/RISCVRegisterInfo.cpp:177
       getFrameLowering(MF)->getFrameIndexReference(MF, FrameIndex, FrameReg);
-  bool IsRVVSpill = RISCV::isRVVSpill(MI, /*CheckFIs*/ false);
+  bool IsRVVSpill = RISCV::isRVVSpill(MI);
   if (!IsRVVSpill)
----------------
Is `IsRVVSpill` used anywhere other than the following if? If not can we call RICV::isRVVSpill as part of the `if` and remove the variable.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128188/new/

https://reviews.llvm.org/D128188