[PATCH] D127031: [CSSPGO][llvm-profgen] Reimplement SampleContextTracker using context trie

Wenlei He via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 27 18:06:58 PDT 2022


wenlei added a comment.

Thanks for the change, and the iterator cleans up quite a bit of duplication. There's one more case left, see inline comment.



================
Comment at: llvm/lib/Transforms/IPO/SampleContextTracker.cpp:86
 
   while (!NodeToUpdate.empty()) {
     ContextTrieNode *Node = NodeToUpdate.front();
----------------
We can use the iterator for this as well? 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127031/new/

https://reviews.llvm.org/D127031



More information about the llvm-commits mailing list