[PATCH] D128124: [X86] Remove unnecessary COPY from EmitLoweredCascadedSelect.

Phoebe Wang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 27 17:33:37 PDT 2022


pengfei accepted this revision.
pengfei added a comment.
This revision is now accepted and ready to land.

LGTM.
Just curious: why no test affected. Is the COPY eliminated laterly?



================
Comment at: llvm/lib/Target/X86/X86ISelLowering.cpp:34573
   // FirstInsertedMBB (the True operand of the SELECT_CC/CMOV nodes).
   MIB.addReg(FirstCMOV.getOperand(2).getReg()).addMBB(FirstInsertedMBB);
-  // Copy the PHI result to the register defined by the second CMOV.
----------------
Use `Op2Reg`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128124/new/

https://reviews.llvm.org/D128124



More information about the llvm-commits mailing list