[PATCH] D124196: [AMDGPU][SILowerSGPRSpills] Spill SGPRs to virtual VGPRs

[Matt Arsenault via Phabricator via llvm-commits]

arsenm accepted this revision.
arsenm added a comment.
This revision is now accepted and ready to land.

LGTM. Might want to introduce an asm printer flag on the implicit_def to mark it's for SGPR spills in the comment



================
Comment at: llvm/lib/Target/AMDGPU/SILowerSGPRSpills.cpp:267
+  // finding the common dominator to get either the dominating spill or a block
+  // dominating all spills. Is there a better way to handle it?
+  SIMachineFunctionInfo *FuncInfo =
----------------
Remove "Is there a better way to handle it?"


================
Comment at: llvm/lib/Target/AMDGPU/SILowerSGPRSpills.cpp:307
+      else if (DomMBB != PrevInsertPt->getParent())
+        I->second = &(*DomMBB->getFirstTerminator());
+    }
----------------
Extra ()s


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124196/new/

https://reviews.llvm.org/D124196