[PATCH] D128681: [AMDGPU][ScheduleDAG] Check for CopyToReg PhysReg clobbers in pre-RA-sched

Stanislav Mekhanoshin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 27 15:59:41 PDT 2022


rampitec added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/ScheduleDAGFast.cpp:451
+    // Allow for multiple uses of same def
+    if (Node && LiveRegDefs[*AI] && LiveRegDefs[*AI]->getNode() == Node)
+      continue;
----------------
The check for LiveRegDefs[*AI] is excessive. If Node is not null the last check will not succeed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128681/new/

https://reviews.llvm.org/D128681



More information about the llvm-commits mailing list