[PATCH] D128664: AMDGPU: Add gfx11 feature to force initializing 16 input SGPRs

Stanislav Mekhanoshin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 27 11:20:14 PDT 2022


rampitec added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUAsmPrinter.cpp:908
+  // reading garbage should be OK.
+  const bool EnablePrivateSegmentWaveOffset = ProgInfo.ScratchBlocks > 0;
   ProgInfo.ComputePGMRSrc2 =
----------------
I would not call scratch_en a wave offset. With architected flat scratch there is no wave offset.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128664/new/

https://reviews.llvm.org/D128664



More information about the llvm-commits mailing list