[PATCH] D128667: [WIP] Add Zstd ELF support

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added a comment.

Tips: you may run `git diff -U0 --no-color --relative 'HEAD^' -- | path/to/llvm-project/clang/tools/clang-format/clang-format-diff.py -p1 -i` to clang-format your local change.



================
Comment at: lld/ELF/Driver.cpp:957
+    if (compression::zlib::isAvailable()) {
+      return true;
+    }
----------------
https://llvm.org/docs/CodingStandards.html#don-t-use-braces-on-simple-single-statement-bodies-of-if-else-loop-statements


================
Comment at: lld/ELF/Driver.cpp:965
+    if (compression::zstd::isAvailable()) {
+      return true;
+    }
----------------
https://llvm.org/docs/CodingStandards.html#don-t-use-braces-on-simple-single-statement-bodies-of-if-else-loop-statements




================
Comment at: lld/ELF/InputSection.h:389
 
-static_assert(sizeof(InputSection) <= 160, "InputSection is too big");
+static_assert(sizeof(InputSection) <= 168, "InputSection is too big");
 
----------------
Wwe should not increase the size of InputSection which may have great impact on memory usage. So I mention that I will prefer handling the lld/ELF part.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128667/new/

https://reviews.llvm.org/D128667