[PATCH] D128435: [AMDGPU] Fix assertion failure on mad with negative immediate addend

Mon Jun 27 08:19:56 PDT 2022

rampitec added a comment.

In D128435#3611418 <https://reviews.llvm.org/D128435#3611418>, @foad wrote:

> In D128435#3608508 <https://reviews.llvm.org/D128435#3608508>, @rampitec wrote:
>
>> LGTM, but I really think we just need to truncate the immediate at selection.
>
> You mean as_i64imm should zero extend *instead* of sign extending?

In this context, yes. Because we essentially ignore high bits anyway.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128435/new/

https://reviews.llvm.org/D128435