[PATCH] D128560: An upcoming patch to LLDB will require the ability to decode base64. This patch adds support for decoding base64 and adds tests.

[serge via Phabricator via llvm-commits]

serge-sans-paille added inline comments.


================
Comment at: llvm/include/llvm/Support/Base64.h:56
 
+constexpr char Inv = 64;
+static char decodeBase64Byte(uint8_t Ch) {
----------------
Maybe use a more explicit name now that it has file-scope, `Base64InvalidByte` or something along these line


================
Comment at: llvm/include/llvm/Support/Base64.h:58
+static char decodeBase64Byte(uint8_t Ch) {
+  static char DecodeTable[] = {
+      Inv, Inv, Inv, Inv, Inv, Inv, Inv, Inv, // ........
----------------
Nit: `static const` 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128560/new/

https://reviews.llvm.org/D128560