[PATCH] D128623: Pass code-model through Module IR to LLC

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added a comment.

Thanks. This makes sense to me.



================
Comment at: llvm/test/tools/llc/codemodel.ll:1
+; RUN: llc %s -o - | FileCheck %s --check-prefix=CHECK-LARGE
+
----------------
Add `; REQUIRES: x86-registered-target`


================
Comment at: llvm/tools/llc/llc.cpp:580
+    if (!CM.hasValue() && CM_IR.hasValue()) {
+      Target->setCodeModel(CM_IR.getValue());
+    }
----------------
drop braces

For `Optional`, the convention is to use its `operator bool()` instead of `hasValue`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128623/new/

https://reviews.llvm.org/D128623