[PATCH] D128427: [LoongArch] Add codegen support for load/store operations

[Ray Wang via Phabricator via llvm-commits]

wangleiat added inline comments.


================
Comment at: llvm/lib/Target/LoongArch/LoongArchISelLowering.cpp:122
+    SDValue AddrHi =
+        SDValue(DAG.getMachineNode(LoongArch::PCALAU12I, DL, Ty, GA), 0);
+    SDValue Addr = SDValue(DAG.getMachineNode(ADDIOp, DL, Ty, AddrHi, GA), 0);
----------------
MaskRay wrote:
> `SDValue AddrHi(DAG.getMachineNode(LoongArch::PCALAU12I, DL, Ty, GA), 0);`
thanks!


================
Comment at: llvm/test/CodeGen/LoongArch/ir-instruction/load-store.ll:29
+; LA64-NEXT:    jirl $zero, $ra, 0
+  %1 = load volatile i32, i32* @G
+  store i32 %a, i32* @G
----------------
MaskRay wrote:
> Switch to opaque pointers.
thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128427/new/

https://reviews.llvm.org/D128427