[PATCH] D128588: [AVR] Fix expanding MOVW for overlapping registers

[Patryk Wychowaniec via Phabricator via llvm-commits]

Patryk27 marked 2 inline comments as done.
Patryk27 added inline comments.


================
Comment at: llvm/test/CodeGen/AVR/pseudo/COPY.mir:31
+    $r23r22 = COPY $r25r24
+    RCALLk @foo, implicit $sp, implicit killed $r24r23
+...
----------------
benshi001 wrote:
> Are these two `implicit killed` in the two RCALLk necessary ?
Without any instruction that actually uses the result of that `COPY`, LLVM seems to generate no code whatsoever - I've thought about `RCALLk` as a simple way of telling LLVM "trust me, that register is read later".

Those don't have to be `killed` though, so to simplify the test, I've just changed them to `RCALLk @foo, implicit $r24r23`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128588/new/

https://reviews.llvm.org/D128588